[Impeller] Use linear sampling for reads in the texture atlas #35618
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I patched this in and noted an improvement to text aliasing, but further improvements for text and the other objects noted in the demo app issue will still be good to have. |
|
This is helping a lot with the rotated text |
zanderso
added
the
autosubmit
…110121) * 94f97c337 Roll Skia from b91dbe274717 to 94602de608e0 (4 revisions) (flutter/engine#35634) * 6ec08c50e Roll Skia from 94602de608e0 to 8c32b0148770 (7 revisions) (flutter/engine#35636) * 9195b7a2f Roll Dart SDK from 03506589f2d0 to c064b9bacc4d (1 revision) (flutter/engine#35637) * f7ec70782 Roll Skia from 8c32b0148770 to a9a05d0bf0c5 (3 revisions) (flutter/engine#35639) * 15cf53acc Image shader dispose (flutter/engine#35640) * ee3cd0d8a Roll Skia from a9a05d0bf0c5 to 147232a3cebc (2 revisions) (flutter/engine#35641) * 5f53ee3b2 [Impeller] Use linear sampling for reads in the texture atlas (flutter/engine#35618) * 4ff7f7b9a Roll Fuchsia Mac SDK from JocShsJvXYeSVjgvW... to Es8SXkqDOYZ5dgYTq... (flutter/engine#35642) * 565cc861e Roll Skia from 147232a3cebc to cc63d5dd13b6 (1 revision) (flutter/engine#35643) * b4af69f02 Roll Dart SDK from c064b9bacc4d to 3042d6196824 (1 revision) (flutter/engine#35644) * 8cc02dc73 Roll Skia from cc63d5dd13b6 to a4744aa054cf (2 revisions) (flutter/engine#35645)
4 participants
This results in a tiny reduction to text jaggies caused by float imprecision.
To solve the problem fully, we ultimately need to render to the atlas with anti aliasing disabled and then apply out own anti aliasing when the text is drawn to the entity pass or offscreen texture (or switch to an alternative text rendering technique).