This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support BoldText for a11y in android #35589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
approved these changes
Aug 22, 2022
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, just some questions
| rootAccessibilityView.getResources().getConfiguration().fontWeightAdjustment; | ||
| boolean shouldBold = | ||
| fontWeightAdjustment != Configuration.FONT_WEIGHT_ADJUSTMENT_UNDEFINED | ||
| && fontWeightAdjustment >= 300; |
Contributor
There was a problem hiding this comment.
Why 300? is there documentation around this value? This should be a constant for readability.
Member
Author
There was a problem hiding this comment.
Added a comment
300 is bold - normal = w700 - w400
Contributor
There was a problem hiding this comment.
Can you also add a constant for the value 300?
static final int kBoldTextAdjustment = 300
hannah-hyj
added
the
autosubmit
Contributor
|
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: flutter/flutter#86187
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.