This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Include TextureViews in the output of Scene.toImage[Sync]" #35587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jonahwilliams I don't think the breakage is related to your PR, but I'm going to leave this open until CI has finished testing the earlier breakages all the way. |
jonahwilliams
approved these changes
Aug 21, 2022
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM if you need to 😄
CaseyHillers
added
the
autosubmit
Contributor
Author
|
There was 7 test failures introduced in this commit compared to the previous. Going to revert for now to try and get back into a green state. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #35527
Breaking Google tests. Googlers see b/243218218