This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make ShaderMaskLayer code builder aware #35534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
reviewed
Aug 19, 2022
| auto shader_rect = SkRect::MakeWH(mask_rect_.width(), mask_rect_.height()); | ||
|
|
||
| if (context.leaf_nodes_builder) { | ||
| context.builder_multiplexer->saveLayer(&paint_bounds(), |
Contributor
There was a problem hiding this comment.
Yes, this is actually the important part of this fix... ;)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
CaseyHillers
added a commit
that referenced
this pull request
Aug 21, 2022
This reverts commit 02f9602.
flar
reviewed
Aug 22, 2022
| dl_paint.setColorSource(shader_.get()); | ||
| } | ||
| context.leaf_nodes_builder->translate(mask_rect_.left(), mask_rect_.top()); | ||
| context.leaf_nodes_builder->drawRect(shader_rect, dl_paint); |
Contributor
There was a problem hiding this comment.
Looks like we forgot a restore here which made the rendering completely fail on internal tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharderMask layer paint use DLBuilder