This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] [Windows] Don't crash if GetPointerType is unsupported #35513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
loic-sharma
requested review from
a-wallen,
cbracken,
itsjustkevin,
muditatandon and
yaakovschectman
loic-sharma
changed the title
Member
Author
|
Blocked by: flutter/flutter#109797 |
loic-sharma
force-pushed
the
flutter-3.2-candidate.5
branch
from
0b7c82a to
4141570
Compare
This was referenced Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #35442 into
flutter-3.2-candidate.5Cherry pick issue: flutter/flutter#109742
The engine's
WindowreferencesGetPointerType, which is supported only on Windows 8 and after. This causes Flutter apps to crash immediately on Windows 7.This introduces
WindowsProcTableto look up Windows APIs dynamically.This bug was introduced in: #31594
Fixes flutter/flutter#109412
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.