This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add Point::AngleTo #35510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Aug 18, 2022
| } | ||
|
|
||
| constexpr Radians AngleTo(const TPoint& p) const { | ||
| return Radians{std::atan2(this->Cross(p), this->Dot(p))}; |
Contributor
There was a problem hiding this comment.
FWIW, I was looking at Chromium code related to this recently and there's some note about atan2 not being precise enough on macOS. I can try to dig it up if we think it's important here.
We may want to document that this method is expensive and backed by atan2, although probably anyone who cares enough to read it will know that...
Member
Author
There was a problem hiding this comment.
I'd be interested in seeing this -- I wonder if the libcxx we use is the same and/or if that leaves us in a different situation. High precision happens to not be super important for how we're using it in the blur, but it may become important for future uses.
Contributor
|
auto-submit
bot
removed
the
autosubmit
Member
|
Blocked on an infra issue flutter/flutter#109797 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by #35491.