Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@perks
Copy link
Contributor

@perks perks commented Aug 18, 2022

@zanderso
reference: dart-lang/sdk#47924

Recently added a standalone binary utility that allows for parsing of precompiled AOT snapshots in order to obtain metadata information from them.

Goal is to get this bundled with Flutter engine distributions and built alongside gen_snapshot so that it is compiled with the correct flags in order to correctly parse snapshots.

Tests for the binary itself live inside of the dart-sdk repo, so do not know if a test is needed/what that would like in this repo

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 18, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 18, 2022

Validations Fail.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@zanderso zanderso requested a review from dnfield August 18, 2022 15:53
@zanderso
Copy link
Member

@dnfield This needs another reviewer since @perks is not part of the Flutter org.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@auto-submit auto-submit bot merged commit bf5582d into flutter:main Aug 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants