This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix transform in TextureContents::RenderToSnaphot passthrough path #35458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Aug 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2022
a-wallen
pushed a commit
to a-wallen/engine
that referenced
this pull request
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by one of the pass elimination patches I landed recently. The path origin was inadvertently getting dropped in the case where
TextureContentsis able to build snapshots using the texture directly.I added parameters to control the path rect in the
GaussianBlurFilterplayground to make smoke testing this aspect possible.Screen.Recording.2022-08-17.at.1.06.03.AM.mov