Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 17, 2022

-[FlutterViewControllerTest testkeyboardWillChangeFrameWillStartKeyboardAnimation] was failing when -[FlutterTextInputPluginTest testInputViewsHasNonNilInputDelegate] was run first. The latter test was adding a FlutterTextInputView to the app, testing it, but not removing it when it was complete. Remove it from the view hierarchy at the end of the test.

I still need to investigate why this test was passing on iOS 15 but fails on iOS 16.

Fixes flutter/flutter#109655

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Aug 17, 2022
@jmagman jmagman marked this pull request as ready for review August 17, 2022 03:33
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2022
@auto-submit auto-submit bot merged commit f86e19f into flutter:main Aug 17, 2022
@jmagman jmagman deleted the removeFromSuperview branch August 17, 2022 18:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2022
a-wallen pushed a commit to a-wallen/engine that referenced this pull request Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-[FlutterViewControllerTest testkeyboardWillChangeFrameWillStartKeyboardAnimation] fails on iOS 16 simulator

2 participants