Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix Metal validation failures on CanRenderTiledTexture/Metal #35449

Merged
auto-submit merged 1 commit into from
Aug 17, 2022
Merged

[Impeller] Fix Metal validation failures on CanRenderTiledTexture/Metal #35449

auto-submit merged 1 commit into from
Aug 17, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Aug 17, 2022 •
edited
Loading

fix flutter/flutter#109648

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight ColdPaleLight self-assigned this Aug 17, 2022
chinmaygarde
chinmaygarde approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2022
@auto-submit auto-submit bot merged commit 3b64bfc into flutter:main Aug 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2022
@engine-flutter-autoroll
3b64bfc [Impeller] Fix Metal validation failures on CanRenderTiledTex…
8a9e571 
…ture/Metal (flutter/engine#35449)
a-wallen pushed a commit to a-wallen/engine that referenced this pull request Aug 18, 2022
@ColdPaleLight
[Impeller] Fix Metal validation failures on CanRenderTiledTexture/Met…
85be339 
…al (flutter#35449)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdero bdero Awaiting requested review from bdero

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ColdPaleLight ColdPaleLight

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Metal validation failures on CanRenderTiledTexture/Metal.

2 participants

@ColdPaleLight @chinmaygarde