This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Don't crash if GetPointerType is unsupported #35442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
a-wallen,
cbracken,
gspencergoog,
moffatman and
yaakovschectman
moffatman
reviewed
Aug 16, 2022
a-wallen
reviewed
Aug 17, 2022
cbracken
reviewed
Aug 17, 2022
cbracken
reviewed
Aug 17, 2022
cbracken
reviewed
Aug 17, 2022
| MockTextInputManager* text_input_manager = new MockTextInputManager(); | ||
| auto windows_proc_table = std::make_unique<MockWindowsProcTable>(); | ||
| auto* text_input_manager = new MockTextInputManager(); | ||
| std::unique_ptr<TextInputManager> text_input_manager_ptr(text_input_manager); |
Member
There was a problem hiding this comment.
Can't remember why this is using new and not make_unique() but definitely feel free to clean it up.
Member
Author
There was a problem hiding this comment.
Sounds good. I'll do it in a follow-up pull request. I need to merge this one back into the beta release branch, which is already has hairy merge conflicts 😅
cbracken
reviewed
Aug 17, 2022
cbracken
reviewed
Aug 17, 2022
cbracken
reviewed
Aug 17, 2022
cbracken
reviewed
Aug 17, 2022
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2022
a-wallen
pushed a commit
to a-wallen/engine
that referenced
this pull request
Aug 18, 2022
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Aug 18, 2022
8 tasks
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Aug 22, 2022
itsjustkevin
pushed a commit
that referenced
this pull request
Aug 22, 2022
This was referenced Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine's
WindowreferencesGetPointerType, which is supported only on Windows 8 and after. This causes Flutter apps to crash immediately on Windows 7.This introduces
WindowsProcTableto look up Windows APIs dynamically.This bug was introduced in: #31594
Fixes flutter/flutter#109412
Pre-launch Checklist
writing and running engine tests.
///).