Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] sRGB to Linear Gamma filter implementation. #35441

Merged
betrevisan merged 18 commits into from
Aug 19, 2022
Merged

[Impeller] sRGB to Linear Gamma filter implementation. #35441

betrevisan merged 18 commits into from
Aug 19, 2022

Conversation

@betrevisan
Copy link
Contributor

@betrevisan betrevisan commented Aug 16, 2022 •
edited
Loading

The changes proposed in this PR implement the sRGB to Linear Gamma filter in Impeller alongside accompanying tests.

Below is a screenshot of the playground. The image on the left is the unfiltered image and the one on the right is the filtered one.

Screen Shot 2022-08-16 at 3 38 05 PM

Solves flutter/flutter#109737.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@betrevisan betrevisan self-assigned this Aug 16, 2022
@betrevisan betrevisan marked this pull request as ready for review August 16, 2022 22:40
bdero
bdero reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a few comments about the recent snapshot changes and respecting the transform. I noticed these problems are also present in the color matrix filter and there's a patch for it here: #35448

@bdero bdero mentioned this pull request Aug 17, 2022
Merged
8 tasks
bdero
bdero approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As mentioned in #35388 (comment), these conversions can be combined later.

@betrevisan betrevisan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@chinmaygarde
Copy link
Member

chinmaygarde commented Aug 18, 2022 •
edited
Loading

The infra issues are being tracked in the sheriff chat. But, this will have to be rebased as well since there are merge conflicts.

@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 18, 2022

  • The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@betrevisan betrevisan merged commit 92bc431 into flutter:main Aug 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
92bc431 [Impeller] sRGB to Linear Gamma filter implementation. (flutt…
fff093d 
…er/engine#35441)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

1 more reviewer

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@betrevisan betrevisan

Labels

e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@betrevisan @chinmaygarde @bdero