This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Mac] Add test for AXPlatformNodeCocoa #35437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Aug 16, 2022
loic-sharma
reviewed
Aug 16, 2022
third_party/accessibility/ax/platform/ax_platform_node_mac_unittest.mm
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
Aug 16, 2022
Adds an initial test of looking up the macOS-specific AXPlatformNodeMac C++ node wrapper and the AXPlatformNodeCocoa Objective-C wrapper, in addition to the existing platform-agnostic accessibility tests that run on macOS today. This is initial test infrastructure to support authoring tests for an upcoming fix to the issue below. Issue: flutter/flutter#102416
Member
Author
|
Added a doc comment for the text fixture class as well. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial test of looking up the macOS-specific AXPlatformNodeMac
C++ node wrapper and the AXPlatformNodeCocoa Objective-C wrapper, in
addition to the existing platform-agnostic accessibility tests that run
on macOS today.
This is initial test infrastructure to support authoring tests for an
upcoming fix to the issue below.
Related issue: flutter/flutter#102416
Fixes: flutter/flutter#109629
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.