[Impeller] Implement drawShadow #35426
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
(Still needs a display list test) |
|
I expect a low impact to gallery raster time benchmarks. |
|
Added a display list playground to demonstrate the behavior (and problems with the approximation):
|
bdero
added
autosubmit
2 participants
Doesn't include the ambient occlusion part (which has a comparatively tiny impact on the shadow color).
The accuracy of these shadows will improve a bit more when I land improvements to the rrect approximation.
Skia:
Impeller:
Fixes flutter/flutter#104715