This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Display list multiplexer #35421
Merged
Display list multiplexer #35421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
JsouLiang
reviewed
Aug 16, 2022
shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
JsouLiang
reviewed
Aug 16, 2022
JsouLiang
reviewed
Aug 16, 2022
JsouLiang
reviewed
Aug 16, 2022
Contributor
|
LGTM, one comment is the return type doesn't match that causing the test to fail. Some others are nits. |
JsouLiang
reviewed
Aug 16, 2022
JsouLiang
previously approved these changes
Aug 16, 2022
JsouLiang
reviewed
Aug 16, 2022
| PostPrerollResult( | ||
| fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger)); | ||
| MOCK_METHOD0(GetCurrentCanvases, std::vector<SkCanvas*>()); | ||
| MOCK_METHOD0(GetCurrentBuilders, std::vector<DisplayListBuilder*>()); |
Contributor
There was a problem hiding this comment.
Test failed in here:
note: unimplemented pure virtual method 'GetCurrentBuilders' in 'MockExternalViewEmbedder'
flar
force-pushed
the
display-list-multiplexer
branch
from
ce144d9 to
7b0055d
Compare
JsouLiang
approved these changes
Aug 16, 2022
JsouLiang
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#109579
This small utility class should enable us to continue embracing the
PaintContext::leaf_nodes_builderclass in subclasses that require access to saveLayer onPaintContext::internal_nodes_canvas.