This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[gn + generator ] add codesign configs for generator tasks in ios/artifacts.zip #35417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
Aug 16, 2022
godofredoc
reviewed
Aug 16, 2022
godofredoc
reviewed
Aug 16, 2022
godofredoc
reviewed
Aug 16, 2022
godofredoc
reviewed
Aug 16, 2022
godofredoc
approved these changes
Aug 16, 2022
XilaiZhang
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2022
… ios/artifacts.zip (flutter/engine#35417)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2022
… ios/artifacts.zip (flutter/engine#35417)
zanderso
reviewed
Aug 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: This change is based on recent changes related to generators: https://flutter-review.googlesource.com/c/recipes/+/32501, https://flutter-review.googlesource.com/c/recipes/+/32500, https://flutter-review.googlesource.com/c/recipes/+/32380,
https://flutter-review.googlesource.com/c/recipes/+/32280.
This commit adds Mac codesign configuration files into ios/artifacts.zip. Since ios/artifacts.zip is produced through global generators, the configuration is embedded into generator script.