Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jaeheon
Copy link
Contributor

@jaeheon jaeheon commented Aug 15, 2022

Replace superclass with _TestBase variant.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jaeheon jaeheon added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 15, 2022
@jaeheon jaeheon merged commit de2640e into flutter:main Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-fuchsia waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants