Fix race in PushingMutlipleFramesSetsUpNewRecordingCanvas. #35412
Conversation
Fixes flutter/flutter#109333 The fixture just continues to push frames indefinitely. The old test was depending on racily checking if a certain number of frames were pushed.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I don't get why the bot is mad. I literally only just edited a file with a unit-test 🤷🏽 . |
jason-simmons
left a comment
jason-simmons
left a comment
There was a problem hiding this comment.
LGTM
Although the ASSERT_GE is redundant. If frames_seen is less than frames_expected, then the test will still be waiting on the countdown latch and will not reach the assert.
chinmaygarde
added
the
autosubmit
2 participants
Fixes flutter/flutter#109333
The fixture just continues to push frames indefinitely. The old test
was depending on racily checking if a certain number of frames were
pushed.