This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Revert special character escaping #35365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 11, 2022 18:17
chinmaygarde
approved these changes
Aug 15, 2022
chinmaygarde
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to escape certain special characters in impeller to avoid invalid depfiles. While this no longer causes an invalid depfile error, unfortunately we now always recompile these files as the ninja expected escaping doesn't work as expected. Some alternatives I tried:
single escape:
/- rebuildsdouble escape:
//- invalidtriple escape:
///rebuildspercent escape:
%%invalidTo add insult to injury, the orginal depfile isn't invalid on windows, only on macOS/linux
Ultimately this was all just a workaround to test URI encoding, but we could also just test that in the framework. I think we should revert this handling here and add integration tests to the framework repo instead.
Fixes flutter/flutter#109257