-
Notifications
You must be signed in to change notification settings - Fork 6k
Avoid object creation during each frame #35343
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
It looks like we will only have one request at same time So we can hold one if (!pending_frame_semaphore_.TryWait()) {
// Multiple calls to Animator::RequestFrame will still result in a
// single request to the VsyncWaiter.
return;
}
|
jason-simmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this causing a significant performance issue?
If the cost of these allocations is noticeable, then one option would be using a collection such as Android's SparseLongArray to hold the pending cookies.
|
|
Validations Fail. |
@jason-simmons help~ 👀 |
|
test-exempt: code refactor with no semantic change |
|
@jason-simmons Got test-exempt and two approver. Would you mind helping me add the autosubmit tag again? |
Choreographer.FrameCallbackwill be called each frameWe should avoid create new object here
There is no need to consider thread safety, it is guaranteed here and here
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.