This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make 'DlImageColorSource' work with 'DlImage's #35258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColdPaleLight
requested review from
chinmaygarde and
flar
and removed request for
chinmaygarde
chinmaygarde
approved these changes
Aug 9, 2022
Contributor
|
Nice! I was about to pick this back up haha but you beat me to it |
dnfield
reviewed
Aug 9, 2022
| if (!image_->skia_image()) { | ||
| return false; | ||
| } | ||
| return image_->skia_image()->isOpaque(); |
Contributor
There was a problem hiding this comment.
nit: consider implementing isOpaque on DlImage. It will be necessary to support the DlDeferredGpuImage down the road.
Contributor
There was a problem hiding this comment.
But also feel free to land this as-is and I'll fix that up when I come back through here :)
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#100984
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.