This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Account for the backend-dependent space of rendered textures in gaussian blur #35257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2022
…d textures in gaussian blur (flutter/engine#35257)
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
…es in gaussian blur (flutter#35257) * Add single pass variation to gaussian blur test * Account for the backend-dependent space of rendered textures in gaussian blur
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#105053.
The issue isn't visible in the regular 2 pass blur, so I added a 1 pass (directional) mode to the playground. However, this also fixes a less common bug in the 2 pass gaussian: Since the alpha mask in the second pass will be inverted, blur inputs with a non-symmetrical alpha mask in the Y direction didn't render correctly prior to this change.
Before:
After:
