This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder API] Add next frame callback #35244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
a-wallen,
cbracken,
chinmaygarde and
yaakovschectman
chinmaygarde
approved these changes
Aug 8, 2022
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM with nits and documentation suggestions.
shell/platform/embedder/embedder.h
Outdated
|
|
||
| //------------------------------------------------------------------------------ | ||
| /// @brief Schedule a callback to be called after the next frame is drawn. | ||
| /// This callback is made on an internal engine managed thread and |
Member
There was a problem hiding this comment.
(or an embedder managed thread if custom task runners are specified)
Member
Author
There was a problem hiding this comment.
Ah, perhaps my original comment is incorrect. This runs on the raster thread, which is created by the embedder (and thus also managed by the embedder?). Should I just say it runs on the raster thread?
Member
Author
There was a problem hiding this comment.
I switched this to say raster thread. I'll leave this conversation open for now, let me know if you'd prefer I go with your original message!
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an embedder API to be notified when the next frame has been drawn. In the future, this will be used by the Windows embedder to hide the window until the first frame has been drawn.
Part of flutter/flutter#41980
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.