This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia from 4722605332ef to 82b9930b1312 (9 revisions) #35242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/4722605332ef..82b9930b1312 2022-08-08 [email protected] Simplify some RP data layout and logic 2022-08-08 [email protected] Drawable: Use the Read/WriteBuffer bulk API for points 2022-08-08 [email protected] Roll vulkan-deps from 4b211a6a98e6 to 5e532d83424e (2 revisions) 2022-08-08 [email protected] Rename getRuleCMakeName() to getRuleSimpleName(). 2022-08-08 [email protected] Move findRule() into bazel_util.go. 2022-08-08 [email protected] Move isFileTarget() to bazel_util.go 2022-08-08 [email protected] [graphite] Add system to support client caching of images 2022-08-08 [email protected] Exporting Bazel with more build flags. 2022-08-08 [email protected] Remove BaseDevice class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-94f7e07d-aff4-498c-8169-1fe1b1a50f50-1659990484
branch
from
981f089 to
4d95286
Compare
skia-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Aug 8, 2022
|
Gold has detected about 1 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Member
|
It looks like the skia gold diffs have been triaged, but the check isn't getting unblocked. @keyonghan Landing this manually to unblock rolls. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2022
Contributor
/cc @Piinks Is this still related to the gold server flake? From the bot side, it reads whatever returns via github API. If the gold server returns |
Contributor
|
Since it has been merged, I cannot see what Gold thought the status was, so I do not know if it is a flake or otherwise. |
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
) https://skia.googlesource.com/skia.git/+log/4722605332ef..82b9930b1312 2022-08-08 [email protected] Simplify some RP data layout and logic 2022-08-08 [email protected] Drawable: Use the Read/WriteBuffer bulk API for points 2022-08-08 [email protected] Roll vulkan-deps from 4b211a6a98e6 to 5e532d83424e (2 revisions) 2022-08-08 [email protected] Rename getRuleCMakeName() to getRuleSimpleName(). 2022-08-08 [email protected] Move findRule() into bazel_util.go. 2022-08-08 [email protected] Move isFileTarget() to bazel_util.go 2022-08-08 [email protected] [graphite] Add system to support client caching of images 2022-08-08 [email protected] Exporting Bazel with more build flags. 2022-08-08 [email protected] Remove BaseDevice class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-94f7e07d-aff4-498c-8169-1fe1b1a50f50-1659990484
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/4722605332ef..82b9930b1312
2022-08-08 [email protected] Simplify some RP data layout and logic
2022-08-08 [email protected] Drawable: Use the Read/WriteBuffer bulk API for points
2022-08-08 [email protected] Roll vulkan-deps from 4b211a6a98e6 to 5e532d83424e (2 revisions)
2022-08-08 [email protected] Rename getRuleCMakeName() to getRuleSimpleName().
2022-08-08 [email protected] Move findRule() into bazel_util.go.
2022-08-08 [email protected] Move isFileTarget() to bazel_util.go
2022-08-08 [email protected] [graphite] Add system to support client caching of images
2022-08-08 [email protected] Exporting Bazel with more build flags.
2022-08-08 [email protected] Remove BaseDevice class
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md