This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support hot reload of asset fonts #35213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Aug 6, 2022
|
|
||
| expect(fontChangeResponse.type, 'Success'); | ||
| expect( | ||
| await completer.future.timeout(const Duration(minutes: 3)), |
Contributor
Author
There was a problem hiding this comment.
Don't know, worried about what happens if this test breaks. Does the entire shard time out at 60 minutes?
zanderso
approved these changes
Aug 8, 2022
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a service extension
_flutter.reloadAssetFontswhich forces the FontCollection to re-open the font manifest and reload any changed fonts, finally dispatching a font change notification to the framework. This is half of the required changes to support flutter/flutter#49230