This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Modify behavior of BuildTarget parameter additional_targets
#35195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbiggs
approved these changes
Aug 5, 2022
Contributor
akbiggs
left a comment
akbiggs
left a comment
There was a problem hiding this comment.
Thanks so much for the fix!
lin-erik
added
the
autosubmit
naudzghebre
approved these changes
Aug 5, 2022
Contributor
|
auto-submit
bot
removed
the
autosubmit
Contributor
|
The failure looks unrelated. CQ gets run against your local branch, so maybe sync to upstream: git fetch upstream
git rebase upstream/main |
…amed to 'build_targets', targets must now be passed in otherwise it will default to building all of flutter
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2022
… and renamed to 'build_targets', targets must now be passed in otherwise it will default to building all of flutter (flutter/engine#35195)
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
…amed to 'build_targets', targets must now be passed in otherwise it will default to building all of flutter (flutter#35195)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently seeing issues with the script failing because we're building targets that aren't necessary. This change modifies the existing behavior, instead defaulting to the targets passed in through the
targetsflag.Internal code search shows there are no current use-cases of the
targetflag being used, so this shouldn't impact any existing code.