Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Aug 5, 2022

For flutter/flutter#108737. Not fixing this in the tool since internal tooling will likely invoke impellerc directly.

This will be tested in the framework repo.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done a smoke test of this on windows? Sometimes things work funky there but maybe this is fine. If it's ok on windows LGTM.

@zanderso
Copy link
Member Author

zanderso commented Aug 5, 2022

Ah, good point. We don't run the 'dart' tests in presubmit. I'll check those on my Windows machine this evening.

@zanderso
Copy link
Member Author

zanderso commented Aug 5, 2022

This does not appear to break anything obvious on Windows. I will land this and monitor the rollers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants