This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update setAssetDirectory service extension to fail if provided path is invalid #35178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
…d path is invalid (flutter/engine#35178)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
…d path is invalid (flutter/engine#35178)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
…d path is invalid (flutter/engine#35178)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
…d path is invalid (flutter/engine#35178)
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
…d path is invalid (flutter/engine#35178)
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2022
* 7a536ee Roll Dart SDK from 0ab07c889f74 to 16cbbc9d5e4b (1 revision) (flutter/engine#35177) * e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutter/engine#35120) * d6931cc Roll Fuchsia Mac SDK from CUZLMQ1lB... to b8WQvI4f0... (flutter/engine#35179) * c1bb5d7 Roll Dart SDK from 16cbbc9d5e4b to aada0a67f81e (1 revision) (flutter/engine#35180) * d45c4c4 ColorFilterLayer change SkColorFilter to DLColorFilter (flutter/engine#34744) * 1a678d2 Roll Fuchsia Linux SDK from BRTz21cLl... to kURZcohuz... (flutter/engine#35182) * cdccc60 Roll Dart SDK from aada0a67f81e to 344a7d12b413 (1 revision) (flutter/engine#35181) * 2c7b4f6 Update setAssetDirectory service extension to fail if provided path is invalid (flutter/engine#35178) * ce3397f fix analysis error (flutter/engine#35187) * eaeae8e Make it possible to obtain `FontWeight` integer value (flutter/engine#35183) * 1f9d87d Analyze all dart code on CI (flutter/engine#35147) * 1cf7023 [impeller] [vulkan] Support textures backed by `vk::Image`s (flutter/engine#35163) * 57f43bd Roll Skia from 098c234c05f7 to f1245dcd35f8 (23 revisions) (flutter/engine#35189)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…09063) * 7a536ee Roll Dart SDK from 0ab07c889f74 to 16cbbc9d5e4b (1 revision) (flutter/engine#35177) * e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutter/engine#35120) * d6931cc Roll Fuchsia Mac SDK from CUZLMQ1lB... to b8WQvI4f0... (flutter/engine#35179) * c1bb5d7 Roll Dart SDK from 16cbbc9d5e4b to aada0a67f81e (1 revision) (flutter/engine#35180) * d45c4c4 ColorFilterLayer change SkColorFilter to DLColorFilter (flutter/engine#34744) * 1a678d2 Roll Fuchsia Linux SDK from BRTz21cLl... to kURZcohuz... (flutter/engine#35182) * cdccc60 Roll Dart SDK from aada0a67f81e to 344a7d12b413 (1 revision) (flutter/engine#35181) * 2c7b4f6 Update setAssetDirectory service extension to fail if provided path is invalid (flutter/engine#35178) * ce3397f fix analysis error (flutter/engine#35187) * eaeae8e Make it possible to obtain `FontWeight` integer value (flutter/engine#35183) * 1f9d87d Analyze all dart code on CI (flutter/engine#35147) * 1cf7023 [impeller] [vulkan] Support textures backed by `vk::Image`s (flutter/engine#35163) * 57f43bd Roll Skia from 098c234c05f7 to f1245dcd35f8 (23 revisions) (flutter/engine#35189)
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from flutter/flutter#109021 . Make sure we error out if the path is invalid so things don't silently fail