This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Embedders use DisplayListBuilder for compositing #35170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
added
affects: engine
Work in progress (WIP)
flutter-dashboard
bot
added
embedder
flar
changed the title
bdero
approved these changes
Aug 4, 2022
Member
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
Looks like the Fuchsia embedder needs to be updated to use the new wrappers as well, but otherwise LGTM. 👍
shell/platform/android/external_view_embedder/external_view_embedder.cc
Outdated
Show resolved
Hide resolved
| .checkerboard_offscreen_layers = checkerboard_offscreen_layers_, | ||
| .frame_device_pixel_ratio = device_pixel_ratio_, | ||
| .raster_cached_entries = &raster_cache_items_, | ||
| .display_list_enabled = frame.display_list_builder() != nullptr, |
Member
There was a problem hiding this comment.
So if I'm understanding this right, this always ends up being true for Impeller because Impeller's Surfaces always produce SurfaceFrames that have a display list builder, right?
Contributor
Author
There was a problem hiding this comment.
Yes, it is true iff Impeller is being used.
We might eventually switch to all DLs all the time even for Skia, but that remains to be seen.
flar
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#104025
Labelling a WIP for now until I can test on Android, but I was able to get an embedded Google Map to show underneath the flutter navigation layers on iPhone with this code. Theoretically it will also work for Android.