Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] EntityPass should cover the whole screen for some blend modes #35157

Merged
auto-submit merged 4 commits into from
Aug 8, 2022
Merged

[Impeller] EntityPass should cover the whole screen for some blend modes #35157

auto-submit merged 4 commits into from
Aug 8, 2022

Conversation

@magicianA
Copy link
Member

@magicianA magicianA commented Aug 4, 2022 •
edited
Loading

Fix flutter/flutter#106051

<----------- Before this patch------------>

截屏2022-08-04 14 51 09

截屏2022-08-04 14 51 15

<----------- After this patch------------>

截屏2022-08-04 14 49 00

截屏2022-08-04 14 49 56

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

bdero
bdero reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up (and for testing against ColorWheel)!

@magicianA magicianA requested a review from bdero August 4, 2022 09:28
bdero
bdero reviewed Aug 4, 2022
View reviewed changes
bdero
bdero approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@magicianA magicianA added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2022
@auto-submit auto-submit bot merged commit 5e33a1f into flutter:main Aug 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
5e33a1f [Impeller] EntityPass should cover the whole screen for some …
53f0d98 
…blend modes (flutter/engine#35157)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
5e33a1f [Impeller] EntityPass should cover the whole screen for some …
9cf1c75 
…blend modes (flutter/engine#35157)
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@magicianA @emilyabest
[Impeller] EntityPass should cover the whole screen for some blend mo…
6be1eea 
…des (flutter#35157)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] EntityPass should cover the whole screen for some blend modes

3 participants

@magicianA @bdero @chinmaygarde