This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impellerc] Namespace user functions in SkSL output #35155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
changed the title
chinmaygarde
approved these changes
Aug 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change made redefinition of builtin functions forbidden in SkSL. To ensure that impellerc's SPIRV to SkSL translator is always generating valid SkSL, this change prefixes user defined functions with a distinctive string. Then, if the name of a user defined function is the same as an SkSL builtin in the input, the prefix added by impellerc in the output will disambiguate from the builtin.