Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Implement sweep gradient #35124

Merged
auto-submit merged 3 commits into from
Aug 8, 2022
Merged

[Impeller] Implement sweep gradient #35124

auto-submit merged 3 commits into from
Aug 8, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Aug 3, 2022 •
edited
Loading

fix flutter/flutter#108878

a7FDZmtxVy

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 3, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ColdPaleLight ColdPaleLight marked this pull request as draft August 3, 2022 13:07
@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented Aug 4, 2022

(The test added)

@ColdPaleLight ColdPaleLight self-assigned this Aug 4, 2022
@ColdPaleLight ColdPaleLight marked this pull request as ready for review August 4, 2022 10:31
bdero
bdero approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks! Just a couple of minor comments about units and where the magic number might live.

bdero
bdero reviewed Aug 8, 2022
View reviewed changes
@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2022
@auto-submit auto-submit bot merged commit 88394df into flutter:main Aug 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
88394df [Impeller] Implement sweep gradient (flutter/engine#35124)
35b17e4
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@ColdPaleLight @emilyabest
[Impeller] Implement sweep gradient (flutter#35124)
93b275d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ColdPaleLight ColdPaleLight

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Implement sweep gradient

2 participants

@ColdPaleLight @bdero