[Impeller] Remove redundant GN flags. #35062
Conversation
These were added to conditionally compile stuff when Impeller only had Metal on Darwin implementation. These are no longer used.
| defines = [] | ||
|
|
||
| if (impeller_supports_platform) { | ||
| defines += [ "IMPELLER_SUPPORTS_PLATFORM=1" ] |
There was a problem hiding this comment.
Do we need to remove references to this from the code?
There was a problem hiding this comment.
Yeah. I built the unit-tests to verify. Going over the code to change these references.
chinmaygarde
added
the
autosubmit
| #include "flutter/fml/synchronization/waitable_event.h" | ||
| #include "flutter/shell/common/shell_io_manager.h" | ||
| #include "flutter/shell/gpu/gpu_surface_gl_delegate.h" | ||
| #if IMPELLER_SUPPORTS_PLATFORM |
There was a problem hiding this comment.
This was done as a hack to make sure that google3 would build.
Can we make sure build_engine=1 still works with this patch applied in google3?
There was a problem hiding this comment.
I expect the rules already ported for the Metal backend for ImpellerC to also work with the OpenGL backend (and others).
There was a problem hiding this comment.
The g3 build hardcodes IMPELLER_SUPPORTS_PLATFORM when depending on impeller. An internal follow-up CL would remove the define from the impeller target.
| #include "flutter/fml/synchronization/waitable_event.h" | ||
| #include "flutter/shell/common/shell_io_manager.h" | ||
| #include "flutter/shell/gpu/gpu_surface_gl_delegate.h" | ||
| #if IMPELLER_SUPPORTS_PLATFORM |
There was a problem hiding this comment.
The g3 build hardcodes IMPELLER_SUPPORTS_PLATFORM when depending on impeller. An internal follow-up CL would remove the define from the impeller target.
4 participants
These were added to conditionally compile stuff when Impeller only had Metal on
Darwin implementation. These are no longer used.