This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Merge SettingsPluginWin32 and superclass #35019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
requested review from
gspencergoog,
loic-sharma,
stuartmorgan-g and
yaakovschectman
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
loic-sharma
approved these changes
Jul 29, 2022
This merges SettingsPluginWin32 into SettingsPlugin. With the removal of the UWP embedder, we can merge Win32-specific implementation classes with their abstract superclasses where those superclasses existed only to support both UWP and Win32. No new tests since this is purely a restructuring of existing code within the Win32 embedder, with no expected change in behaviour. Issue: flutter/flutter#108386
cbracken
commented
Jul 29, 2022
| virtual void StopWatching() = 0; | ||
| virtual void StopWatching(); | ||
|
|
||
| protected: |
Member
Author
There was a problem hiding this comment.
These remain protected rather than being made private since they're overridden by the mock and used in the tests in settings_plugin_unittests.cc.
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
This merges SettingsPluginWin32 into SettingsPlugin. With the removal of the UWP embedder, we can merge Win32-specific implementation classes with their abstract superclasses where those superclasses existed only to support both UWP and Win32. No new tests since this is purely a restructuring of existing code within the Win32 embedder, with no expected change in behaviour. Issue: flutter/flutter#108386
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This merges SettingsPluginWin32 into SettingsPlugin. With the removal of the UWP embedder, we can merge Win32-specific implementation classes with their abstract superclasses where those superclasses existed only to support both UWP and Win32. No new tests since this is purely a restructuring of existing code within the Win32 embedder, with no expected change in behaviour. Issue: flutter/flutter#108386
This was referenced Sep 1, 2022
cbracken
pushed a commit
that referenced
this pull request
Sep 7, 2022
The #35019 didn't merge SettingsPluginWin32's constructor and destructor. This PR adds them and fix SettingsPlugin to re-enable it to watch the theme changes. This PR is part of flutter/flutter#110700. No changes in the flutter/tests repo.
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
The flutter#35019 didn't merge SettingsPluginWin32's constructor and destructor. This PR adds them and fix SettingsPlugin to re-enable it to watch the theme changes. This PR is part of flutter/flutter#110700. No changes in the flutter/tests repo.
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
The flutter#35019 didn't merge SettingsPluginWin32's constructor and destructor. This PR adds them and fix SettingsPlugin to re-enable it to watch the theme changes. This PR is part of flutter/flutter#110700. No changes in the flutter/tests repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges SettingsPluginWin32 into SettingsPlugin.
With the removal of the UWP embedder, we can merge Win32-specific
implementation classes with their abstract superclasses where those
superclasses existed only to support both UWP and Win32.
No new tests since this is purely a restructuring of existing code
within the Win32 embedder, with no expected change in behaviour.
Covered by existing tests in settings_plugin_unittests.cc.
Issue: flutter/flutter#108386
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.