Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[gn] mac entitlement config when dart sdk is non prebuilt #35016

Merged
auto-submit merged 2 commits into from
Aug 4, 2022
Merged

[gn] mac entitlement config when dart sdk is non prebuilt #35016

auto-submit merged 2 commits into from
Aug 4, 2022

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Jul 29, 2022 •
edited
Loading

a followup from #34605, to add mac entitlement config when dart sdk is not prebuilt.

@XilaiZhang XilaiZhang changed the title non prebuilt entitlement [gn] mac entitlement config when dart sdk is non prebuilt Jul 29, 2022
@CaseyHillers CaseyHillers requested a review from whesse August 1, 2022 14:59
zanderso
zanderso reviewed Aug 1, 2022
View reviewed changes
build/archives/BUILD.gn Outdated
]
if (is_mac) {
# Mac artifacts sometimes use mac and sometimes darwin. Standardizing the
# names will require changes in the list of artifacts the tool is downloading.
Copy link
Member

@zanderso zanderso Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like this comment should be a TODO with a link to a GitHub issue.

Copy link
Contributor Author

@XilaiZhang XilaiZhang Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm I am not familiar with the context of this part, I just copied this paragraph. Maybe the author @godofredoc could help take a look, thank you

@zanderso
Copy link
Member

zanderso commented Aug 4, 2022

From PR review triage: @XilaiZhang I think it's probably safe to convert it to a TODO and file an issue and we can follow-up with @godofredoc afterwords.

@godofredoc
Copy link
Contributor

godofredoc commented Aug 4, 2022

From PR review triage: @XilaiZhang I think it's probably safe to convert it to a TODO and file an issue and we can follow-up with @godofredoc afterwords.

There is a bug already for this, let me find it

@godofredoc
Copy link
Contributor

godofredoc commented Aug 4, 2022

From PR review triage: @XilaiZhang I think it's probably safe to convert it to a TODO and file an issue and we can follow-up with @godofredoc afterwords.

There is a bug already for this, let me find it

flutter/flutter#105351 is where we are documenting all those details.

@XilaiZhang
Copy link
Contributor Author

XilaiZhang commented Aug 4, 2022

Great, thanks everyone! I will remove this block of text

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
@auto-submit auto-submit bot merged commit 6f47e37 into flutter:main Aug 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
6f47e37 [gn] mac entitlement config when dart sdk is non prebuilt (fl…
fbb7ad6 
…utter/engine#35016)
@XilaiZhang XilaiZhang deleted the xilaizhang-dart-1 branch August 4, 2022 23:33
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Aug 5, 2022
@XilaiZhang @betrevisan
[gn] mac entitlement config when dart sdk is non prebuilt (flutter#35016
b885a82 
)
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@XilaiZhang @emilyabest
[gn] mac entitlement config when dart sdk is non prebuilt (flutter#35016
9135e07 
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@godofredoc godofredoc Awaiting requested review from godofredoc

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@whesse whesse Awaiting requested review from whesse

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XilaiZhang @zanderso @godofredoc