Fetch the ARM64-host clang on Mac and Linux ARM64. #35003
Conversation
Mac ARM64 continues to also fetch the X64-host toolchain because the GN files that need to updated live in another repository, so this cannot be done atomically.
|
@rmacnak-google are you aware of whether we have an arm64-windows toolchain floating around as well? There are a couple contributors working on arm64 Windows support at the moment, though initially the goal is x64 windows cross-compiling for arm64 windows. Not at all urgent right now, but something that we'll eventually want to support. |
|
The toolchain we get from Fuchsia supports arm64-windows as a target, and we're using that in Dart, but it doesn't provide for arm64-windows hosts (list of available hosts). An external contributor is using MSVC to compile on an arm64-windows host. |
| { | ||
| 'package': 'fuchsia/third_party/clang/mac-amd64', | ||
| 'version': 'NyopqdQvXY11sckCZIz7FdXLgQZep1ssg1IYBX09ZPwC' | ||
| 'version': 'git_revision:3a20597776a5d2920e511d81653b4d2b6ca0c855' |
There was a problem hiding this comment.
Is this going to confuse or get clobbered by the toolchain autorollers? E.g. https://autoroll.skia.org/r/clang-mac-flutter-engine
There was a problem hiding this comment.
Also, shouldn't we still be tracking the toolchain that the Fuchsia toolchain team is officially releasing?
There was a problem hiding this comment.
Revisions instead of instance ids make it easier to see whether the platforms are in sync and make it easier to match things back to the source repositories. Dart's DEPS and Fuchsia's manifest both use revisions instance of instance ids. This is the revision currently used by Fuchsia integration.
There was a problem hiding this comment.
If changes aren't also made to the autoroller, then the next autoroller roll will clobber these back to instance ids (if it can understand the new layout at all.)
Mac ARM64 continues to also fetch the X64-host toolchain because the GN files that need to updated live in another repository, so this cannot be done atomically.
3 participants
Mac ARM64 continues to also fetch the X64-host toolchain because the GN files that need to updated live in another repository, so this cannot be done atomically.
Bug: flutter/flutter#103386