Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@whesse
Copy link
Contributor

@whesse whesse commented Jul 29, 2022

Package dart2js_info added a dependency on vm_snapshot_analysis.
Both packages are inside the Dart SDK source checkout.

The relative path to the new package must be added to
dependency_overrides in the pubspec.yaml.

Pre-launch Checklist

  • [x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • [x ] I signed the [CLA].
  • [x ] All existing and new tests are passing.

@whesse whesse requested review from IslinaS, a-siva and zanderso July 29, 2022 09:51
Package dart2js_info added a dependency on vm_snapshot_analysis.
Both packages are inside the Dart SDK source checkout.

The relative path to the new package must be added to
dependency_overrides in the pubspec.yaml.
@iskakaushik iskakaushik added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
@auto-submit auto-submit bot merged commit 12a9739 into flutter:main Jul 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2022
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants