This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Don't make playgrounds implicitly be test fixtures. #34957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playground are ideal for prototyping Impeller targets but they also assume that the user is a Google Test. This separates playgrounds into a base library that can be used outside of tests as well as a playground_test target that is specifically used by Google Test cases. No change in functionality. Needs buildroot patch flutter/buildroot#596
bdero
approved these changes
Jul 27, 2022
chinmaygarde
added
e: impeller
autosubmit
This comment was marked as outdated.
This comment was marked as outdated.
auto-submit
bot
removed
the
autosubmit
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playgrounds are ideal for prototyping Impeller targets but they also assume that
the user is a Google Test. This separates playgrounds into a base library that
can be used outside of tests as well as a playground_test target that is
specifically used by Google Test cases.
No change in functionality.
Needs buildroot patch flutter/buildroot#596