optimized IncomingMessageDispatcher::HandleMessage a bit #34954
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| const std::function<void(void)>& input_block_cb, | ||
| const std::function<void(void)>& input_unblock_cb) { | ||
| std::string channel(message.channel); | ||
| const std::string& channel = message.channel; |
There was a problem hiding this comment.
message.channel is a const char*, so I'm not sure what this is supposed to be changing. AFAICT this is doing the same thing, but much more mysteriously since it relies on understanding reference lifetime extension of an anonymous std::string instance.
|
test-exempt: refactor with no semantic change |
|
The presub failures need a rebase and are unrelated to the patch. |
gaaclarke
force-pushed
the
faster-desktop-dispatch
branch
from
b0e91de to
ad3a55e
Compare
* optimized IncomingMessageDispatcher::HandleMessage a bit. * removed std::string ref
4 participants
I noticed a few simple optimizations while reading through the desktop code:
callbacks_instead of 2Removed copy of the channel namePre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.