Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update reference to python3 with vpython3 #34950

Merged
auto-submit merged 1 commit into from
Jul 28, 2022
Merged

Update reference to python3 with vpython3 #34950

auto-submit merged 1 commit into from
Jul 28, 2022

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Jul 27, 2022 •
edited
Loading

Summary

This PR aims to match functionality in flutter/engine as seen here: d3dc614

We believe this will reduce flakiness on the Windows bots by limiting
the interaction of the global Python install and the self-contained
hermetic vpython that ships with depot_tools.
and solves a broader issue described [here].(flutter/flutter#108474)

This is a continuation PR per #34894 (review)

Related Issues Fixed by this PR

flutter/flutter#108479

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@a-wallen a-wallen requested a review from cbracken July 27, 2022 21:43
@a-wallen a-wallen marked this pull request as ready for review July 27, 2022 23:59
cbracken
cbracken approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@a-wallen a-wallen added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 28, 2022
@auto-submit auto-submit bot merged commit abd5520 into flutter:main Jul 28, 2022
@cbracken cbracken mentioned this pull request Jul 28, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
abd5520 Update reference to python3 with vpython3 (flutter/engine#34950)
5b24eed
@a-wallen
Copy link
Contributor Author

a-wallen commented Jul 28, 2022 •
edited
Loading

#closes flutter/flutter#108479

This was referenced Jul 28, 2022
Closed
Open
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 29, 2022
@a-wallen @betrevisan
Update reference to python3 with vpython3 (flutter#34950)
0a59700
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-wallen @cbracken