Remove the OpenGL backend on iOS #34913
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| ] | ||
|
|
||
| frameworks = [ | ||
| "AudioToolbox.framework", |
There was a problem hiding this comment.
Completely unrelated, but why in the world do we link in AudioToolbox? I think this is code I wrote my first week at Google :/
There was a problem hiding this comment.
The platform plugin interface does provide an API for playing a sound:
https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm#L96
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Looks good to me and this covers all the files I can think to get rid of.
zanderso
force-pushed
the
always-choose-metal
branch
from
3feb3f7 to
2311203
Compare
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
🥳
LGTM, let's see how this does on a full TAP run...
* 125a4b4 Roll Skia from c334e0933076 to a9d44a41296f (1 revision) (flutter/engine#34909) * 763feb4 Roll Skia from a9d44a41296f to b7e27876f093 (1 revision) (flutter/engine#34911) * 9388b8e [Impeller] [vulkan] Wire-up creating pipeline (flutter/engine#34890) * bdcc960 Roll buildroot deps (flutter/engine#34894) * 9a86864 Roll Dart SDK from c77db322733f to 52c6d32a67b6 (1 revision) (flutter/engine#34914) * 1a9eb88 Roll Fuchsia Linux SDK from JG8eZzFic... to 4xjxrGUrD... (flutter/engine#34915) * 4c613a6 Remove the OpenGL backend on iOS (flutter/engine#34913)
…8392) * 125a4b4 Roll Skia from c334e0933076 to a9d44a41296f (1 revision) (flutter/engine#34909) * 763feb4 Roll Skia from a9d44a41296f to b7e27876f093 (1 revision) (flutter/engine#34911) * 9388b8e [Impeller] [vulkan] Wire-up creating pipeline (flutter/engine#34890) * bdcc960 Roll buildroot deps (flutter/engine#34894) * 9a86864 Roll Dart SDK from c77db322733f to 52c6d32a67b6 (1 revision) (flutter/engine#34914) * 1a9eb88 Roll Fuchsia Linux SDK from JG8eZzFic... to 4xjxrGUrD... (flutter/engine#34915) * 4c613a6 Remove the OpenGL backend on iOS (flutter/engine#34913)
4 participants
With the deprecation of support for iOS 9 & 10, Metal is available on all supported iOS versions.