[Impeller] [vulkan] Wire-up creating pipeline #34890
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
All nits, otherwise LGTM.
| // found in the LICENSE file. | ||
|
|
||
| #include "impeller/renderer/backend/vulkan/pipeline_library_vk.h" | ||
| #include <optional> |
There was a problem hiding this comment.
Super minor nit: Newline between header types.
|
|
||
| namespace impeller { | ||
|
|
||
| struct PipelineVKCreateInfo { |
There was a problem hiding this comment.
Super minor nit: Per the naming conventions follows elsewhere, PipelineCreateInfoVK.
|
|
||
| // |Pipeline| | ||
| ~PipelineVK() override; | ||
| ~PipelineVK() override = default; |
There was a problem hiding this comment.
Super minor nit: OOL this (and also especially virtuals).
| : Pipeline(std::move(library), std::move(desc)), | ||
| pipeline_(std::move(create_info->pipeline)), | ||
| render_pass_(std::move(create_info->render_pass)) { | ||
| is_valid_ = pipeline_ && render_pass_; |
There was a problem hiding this comment.
Perhaps add an operator bool to PipelineVKCreateInfo or an IsValid call?
chinmaygarde
changed the title
iskakaushik
added
the
autosubmit
* 125a4b4 Roll Skia from c334e0933076 to a9d44a41296f (1 revision) (flutter/engine#34909) * 763feb4 Roll Skia from a9d44a41296f to b7e27876f093 (1 revision) (flutter/engine#34911) * 9388b8e [Impeller] [vulkan] Wire-up creating pipeline (flutter/engine#34890) * bdcc960 Roll buildroot deps (flutter/engine#34894) * 9a86864 Roll Dart SDK from c77db322733f to 52c6d32a67b6 (1 revision) (flutter/engine#34914) * 1a9eb88 Roll Fuchsia Linux SDK from JG8eZzFic... to 4xjxrGUrD... (flutter/engine#34915) * 4c613a6 Remove the OpenGL backend on iOS (flutter/engine#34913)
…8392) * 125a4b4 Roll Skia from c334e0933076 to a9d44a41296f (1 revision) (flutter/engine#34909) * 763feb4 Roll Skia from a9d44a41296f to b7e27876f093 (1 revision) (flutter/engine#34911) * 9388b8e [Impeller] [vulkan] Wire-up creating pipeline (flutter/engine#34890) * bdcc960 Roll buildroot deps (flutter/engine#34894) * 9a86864 Roll Dart SDK from c77db322733f to 52c6d32a67b6 (1 revision) (flutter/engine#34914) * 1a9eb88 Roll Fuchsia Linux SDK from JG8eZzFic... to 4xjxrGUrD... (flutter/engine#34915) * 4c613a6 Remove the OpenGL backend on iOS (flutter/engine#34913)
2 participants
No description provided.