Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Implement radial gradient #34875

Merged
auto-submit merged 3 commits into from
Jul 25, 2022
Merged

[Impeller] Implement radial gradient #34875

auto-submit merged 3 commits into from
Jul 25, 2022

Conversation

@magicianA
Copy link
Member

@magicianA magicianA commented Jul 25, 2022 •
edited
Loading

Fix flutter/flutter#104716

example:
image

FYI: in impeller/aiks/paint.h, I found std::shared_ptr<LinearGradientContents> contents; I assume that this is not convenient for future develop, and add a layer of abstraction of class PathContents. Please correct me if I am wrong.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@chinmaygarde chinmaygarde self-assigned this Jul 25, 2022
chinmaygarde
chinmaygarde approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. This has the same limitations as linear gradients today w.r.t the number of stops. But we can tackle that at a later point.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2022
@auto-submit auto-submit bot merged commit c0c14e8 into flutter:main Jul 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c0c14e8 [Impeller] Implement radial gradient (flutter/engine#34875)
5136d8e
@ColdPaleLight ColdPaleLight mentioned this pull request Jul 26, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@magicianA magicianA

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Implement radial gradients

3 participants

@magicianA @chinmaygarde @bdero