Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add entrypoint annotations to FragmentProgram fields #34804

Merged
auto-submit merged 1 commit into from
Jul 21, 2022
Merged

Add entrypoint annotations to FragmentProgram fields #34804

auto-submit merged 1 commit into from
Jul 21, 2022

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jul 21, 2022

These are written from FragmentProgram.initFromAsset in the C++ code.

@zanderso zanderso requested a review from jonahwilliams July 21, 2022 03:38
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 21, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams
jonahwilliams approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was this the cause of the other native crash ?

@zanderso
Copy link
Member Author

zanderso commented Jul 21, 2022

It would have caused a crash in release or profile mode. I'll upload a framework patch that's working for me in debug mode shortly.

@zanderso
Copy link
Member Author

zanderso commented Jul 21, 2022

flutter/flutter#108071 <- Compiles ink_sparkle to iplr and uses FragmentProgram.fromAsset to load it.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2022
@auto-submit auto-submit bot merged commit 890b71f into flutter:main Jul 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
890b71f Add entrypoint annotations to FragmentProgram fields (flutter…
a85e955 
…/engine#34804)
@zanderso zanderso deleted the fp-add-annotations branch July 21, 2022 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @jonahwilliams