Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert dart rolls #34657 and #34666 #34668

Merged
GaryQian merged 1 commit into from
Jul 14, 2022
Merged

Revert dart rolls #34657 and #34666 #34668

GaryQian merged 1 commit into from
Jul 14, 2022

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Jul 14, 2022

Reverts #34657 and #34666

Blocking Flutter engine -> framework roll, https://github.com/flutter/flutter/pull/107653/checks?check_run_id=7341814911

package:flutter_driver/src/driver/timeline_summary.dart 414:7   TimelineSummary._averageInMillis
package:flutter_driver/src/driver/timeline_summary.dart 72:12   TimelineSummary.computeAverageFrameRasterizerTimeMillis
package:flutter_driver/src/driver/timeline_summary.dart 232:47  TimelineSummary.summaryJson```

@GaryQian GaryQian added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 14, 2022
@GaryQian GaryQian merged commit ec6391a into flutter:main Jul 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2022
@engine-flutter-autoroll
ec6391a Revert dart rolls flutter#34657 and flutter#34666 (flutter/en…
f62bd91 
…gine#34668)
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 15, 2022
@GaryQian @betrevisan
Revert dart rolls flutter#34657 and flutter#34666 (flutter#34668)
94d2c20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaryQian @zanderso