Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@naudzghebre
Copy link
Contributor

No description provided.

Copy link
Contributor

@akbiggs akbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we verify these are unused? I know we were told they shouldn't be used by V2 but just wondering what components we tested with.

@naudzghebre
Copy link
Contributor Author

Well, I was the one that added Environment and Loader to the jit runner's manifest, sort of unnecessarily, when I was trying to model the runner after the legacy_test_runner, but the runners aren't using those services directly. And config-data I see is being used for v1/v2 components under the flutter runner but not the dart runner. In fuchsia.git only workstation is routing config-data to the dart runner, but i believe this is because we have the use declaration here.

@naudzghebre
Copy link
Contributor Author

My understanding is components that access "/config/data" need config-data, which we don't do in the dart_runner.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants