This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: Avoid attaching view twice when loading view in FlutterViewController #34642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
force-pushed
the
attach_view_twice
branch
from
50028ee to
4126a4c
Compare
cyanglaz
commented
Jul 13, 2022
| // The implementation in viewDidLoad requires the viewControllers.viewLoaded is true. | ||
| // Accessing the view to make sure the view loads in the memory, | ||
| // which makes viewControllers.viewLoaded true. | ||
| XCTAssertNotNil(view); |
Contributor
Author
There was a problem hiding this comment.
This is an existing bug where it crashes in ios_debug_sim_unopt because view is not loaded into memory. I'm not sure how it passed on CI but it constantly fails on my local.
cyanglaz
commented
Jul 13, 2022
|
|
||
| - (void)attachView { | ||
| self.iosPlatformView->attachView(); | ||
| [_textInputPlugin.get() setupIndirectScribbleInteraction:self.viewController]; |
Contributor
Author
There was a problem hiding this comment.
I don't think this line should be belong to attachView, I move it to addInternalPlugins, which is also called every time in viewDidLoad.
dnfield
approved these changes
Jul 14, 2022
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 14, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
iosPlatformView->attachView();is only called once during viewDidLoad in engine.Also fixed a trivial bug in FlutterViewControllerTests.
Also moved
[_textInputPlugin.get() setupIndirectScribbleInteraction:self.viewController];out ofattachViewFixes: flutter/flutter#106283
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.