Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@whesse
Copy link
Contributor

@whesse whesse commented Jul 12, 2022

The BUILD.gn files include support for creating a zip archive of the Dart SDK for an engine build
in the case that a prebuilt Dart SDK has been downloaded.

Extend this support for archiving the Dart SDK to the case where it is built from source during an engine build.
This is needed to support automated build and test of tip-of-tree and pre-submit builds of the engine and Dart.

Bug: flutter/flutter#106494

@whesse whesse requested a review from CaseyHillers July 12, 2022 09:38
@whesse
Copy link
Contributor Author

whesse commented Jul 12, 2022

This is not working, because no gn target I can find is listing $root_out_dir/dart-sdk as an output.
The zip target template requires its inputs to be the output of some target that it depends on directly or indirectly.

No target in Dart's sdk build rules lists the directory as an output, only the individual files that are created. So a major addition to the build rules would be needed to make a target whose output was the entire directory.

I would suggest removing the approval of this PR until it can be fixed.

@whesse
Copy link
Contributor Author

whesse commented Jul 12, 2022

Closing the PR. Either more extensive changes need to be made, or the archive creation must be moved out of the build process.

@whesse whesse closed this Jul 12, 2022
@whesse
Copy link
Contributor Author

whesse commented Jul 19, 2022

I was able to fix this PR by switching from the zip_bundle template to the zip_bundle_from_file template.
Because that template has no inputs, the target correctly depends on its create_sdk dependency, and
rebuilds the zip file if that target is rebuilt. If the create_sdk dependency does not need to be rebuilt, then
the zip file is left as-is.

@whesse whesse force-pushed the archive-built-sdk branch from b9c87f0 to 2855967 Compare July 19, 2022 16:10
@CaseyHillers CaseyHillers requested a review from XilaiZhang July 19, 2022 16:39
@XilaiZhang
Copy link
Contributor

Thanks for the info Casey! I can add entitlement config for this block.

@whesse
Copy link
Contributor Author

whesse commented Jul 19, 2022

Do you want to add it in this PR, or should I land it?

@XilaiZhang
Copy link
Contributor

Feel free to land it sir. Its just a for my info thing that I will remember to do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants