This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Increase IO thread's priority on iOS to avoid stucks #34568
Merged
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeatse
changed the title
Contributor
|
Could you increase the IO thread's priority in Android? |
Contributor
Author
@JsouLiang From the linked issues it seems this problem is only affecting iOS devices. On android the status quo is good enough so without a suitable reason I have no idea which priority should I tune it to. Any suggestion? |
Contributor
|
Lets do it for Android in a separate patch. |
dnfield
approved these changes
Jul 11, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM
Priority inversion can occur when we have the platform thread waiting on a lower priority thread. We should fix this on Android too. @jason-simmons tells me he has a patch in the works to do that.
dnfield
added
the
autosubmit
jason-simmons
approved these changes
Jul 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2022
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
Jul 11, 2022
|
hello，Is there a release plan and in which version? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we remove the latch in Shell::OnPlatformViewCreated, the priority of IO thread should not be too low, otherwise the app will be stuck more often.
Fixes flutter/flutter#107351 and flutter/flutter#106773
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.