This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove canvas render test skia bug workarounds #34513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
approved these changes
Jul 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#86713
We have workarounds in the DisplayList render tests for the following Skia bugs that
appear to have beenare now fixed:https://bugs.chromium.org/p/skia/issues/detail?id=12199
https://bugs.chromium.org/p/skia/issues/detail?id=12200
This PR removes the workarounds for those bugs so we have more complete testing
but the Skia bugs have not been marked closed so I will follow up with Skia to see if we can trust the fixes to remain stable.